-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add method to set a fixed container mac address #616
add method to set a fixed container mac address #616
Conversation
Add method WithMacAddress to set a fixed mac address to a container in TestContainersBuilder. As background information: I want to test software that requires a license key that is tied to the mac address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your pull request 🙏. I suggest to rename macaddress
to macAddress
(maybe it is better to push these changes all at once). Can you please add a test to TestcontainersContainerTest
?
src/Testcontainers/Configurations/Containers/ITestcontainersConfiguration.cs
Outdated
Show resolved
Hide resolved
src/Testcontainers/Configurations/Containers/TestcontainersConfiguration.cs
Outdated
Show resolved
Hide resolved
src/Testcontainers/Configurations/Containers/TestcontainersConfiguration.cs
Outdated
Show resolved
Hide resolved
src/Testcontainers/Configurations/Containers/TestcontainersConfiguration.cs
Outdated
Show resolved
Hide resolved
src/Testcontainers/Configurations/Containers/TestcontainersConfiguration.cs
Outdated
Show resolved
Hide resolved
rename macaddress to macAddress Co-authored-by: Andre Hofmeister <[email protected]>
rename macaddress to macAddress Co-authored-by: Andre Hofmeister <[email protected]>
rename macaddress to macAddress Co-authored-by: Andre Hofmeister <[email protected]>
…nfiguration.cs fix typo Co-authored-by: Andre Hofmeister <[email protected]>
…figuration.cs rename macaddress to macAddress Co-authored-by: Andre Hofmeister <[email protected]>
…figuration.cs rename macaddress to macAddress Co-authored-by: Andre Hofmeister <[email protected]>
…figuration.cs add inherit doc Co-authored-by: Andre Hofmeister <[email protected]>
rename macaddress to macAddress Co-authored-by: Andre Hofmeister <[email protected]>
rename macaddress to macAddress Co-authored-by: Andre Hofmeister <[email protected]>
…figuration.cs rename macaddress to macAddress Co-authored-by: Andre Hofmeister <[email protected]>
add test for the feature to set a fixed mac address for a container
Thanks for the quick review! I executed the suggested renaming and added a test. Viele Grüße aus dem Schwarzwald. ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the contribution.
Viele Grüße aus dem Schwarzwald. ;)
Grüße zurück 😀
Add method 'WithMacAddress' to set a fixed mac address to a container in TestContainersBuilder. As background information to why I need this: I want to test software that requires a license key that is tied to the mac address.