Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for MariaDB. #520

Closed
wants to merge 1 commit into from
Closed

Adding support for MariaDB. #520

wants to merge 1 commit into from

Conversation

renemadsen
Copy link
Contributor

Adding support for MariaDBs MARIADB_ROOT_PASSWORD.

HofmeisterAn
HofmeisterAn reviewed Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I know Sonar will complain. Can't we inherit from the MySql classes (MySqlTestcontainerConfiguration, MariaDbTestcontainer)?

I can take care of the XML comments too.

src/Testcontainers/Configurations/Modules/Databases/MariaDbTestcontainerConfiguration.cs Outdated Show resolved Hide resolved
src/Testcontainers/Configurations/Modules/Databases/MariaDbTestcontainerConfiguration.cs Outdated Show resolved Hide resolved
src/Testcontainers/Containers/Modules/Databases/MariaDbTestcontainer.cs Outdated Show resolved Hide resolved
@renemadsen
Copy link
Contributor Author

LGTM, but I know Sonar will complain.

Why will Sonar complain?

Fixed the summary comments.
Also switched to using Pomelo.EntityFrameworkCore.MySql, since it's being maintained openly on github whereas the MySql.Data is maintaned by Oracle. This affects the MySQL testing container also.

@HofmeisterAn
Copy link
Collaborator

Why will Sonar complain?

Code duplication.

HofmeisterAn
HofmeisterAn approved these changes Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 I'll merge it tomorrow — thanks. If you like, you can squash the commits and use a semantic commit message to follow the repository schema.

I just notice that we skip those paths regarding code duplication.

@renemadsen
feat: Adding support for MariaDB.
9217fbf 
feat: Adding support for MariaDBs MARIADB_ROOT_PASSWORD.
feat: Changing MySQL and MariaDB to use Pomelo.EntityFrameworkCore.MySql, since it's more up to date for both DB types.
@HofmeisterAn
Copy link
Collaborator

f5d471c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HofmeisterAn HofmeisterAn HofmeisterAn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renemadsen @HofmeisterAn