Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource reaper diagnostics #450

Closed
wants to merge 2 commits into from
Closed

Add resource reaper diagnostics #450

wants to merge 2 commits into from

Conversation

PSanetra
Copy link
Contributor

@PSanetra PSanetra commented May 1, 2022

This PR add diagnostics information to ResourceReaperException to debug #449

PSanetra added 2 commits May 1, 2022 17:59
@PSanetra
[#NON] #IMPLEMENT 'assemblyName: DotNet.Testcontainers; function: Ins…
0f7c9c3 
…pectAsync'

{Add InspectAsync method for querying inspection information from a Testcontainer.}
@PSanetra
[testcontainers#449] #IMPLEMENT 'assemblyName: DotNet.Testcontainers;…
b83fcf0 
… function: ResourceReaper'

{Add diagnostics information to ResourceReaperException.}
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

96.9% 96.9% Coverage
0.0% 0.0% Duplication

@HofmeisterAn
Copy link
Collaborator

Good idea! I changed the access modifier for Task<ContainerInspectResponse> InspectContainer to internal. Until now, the library don't expose anything from Docker.DotNet.Models. Of course, this doesn't have to be the case in the future, but I'd like to keep it consistent for now. Lets see what logs we get. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PSanetra @HofmeisterAn