-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Get sqlcmd utility file path from container instead of const file path #1221
fix: Get sqlcmd utility file path from container instead of const file path #1221
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for preparing the PR. I would like to wait a few more days to see if MS decides whether they will add symlink support (or placing the commands in the base path) or not: microsoft/mssql-docker#892 (comment).
Sure no problem :) |
ed84868
to
6c9854a
Compare
Expose MsSqlContainer.GetSqlCmdPathAsync as internal
# Conflicts: # src/Testcontainers.MsSql/MsSqlBuilder.cs # src/Testcontainers.MsSql/MsSqlContainer.cs
Even if Microsoft adds symlink support, changes will be neccessary depending on tool version (especially regarding encryption flags). |
Is this PR still in consideration for being merged or not? |
Yes, but I still hope that Microsoft responds to the issue and decides to address it properly in their image. IIRC, this affects older versions as well. If we need to work around the issue, we will have to fix it for the older versions of MSSQL and different versions of |
Since Microsoft is taking their time to address the issue, I think we should move forward with this pull request. Could we adjust the command to determine the
It should work for all image versions, including new releases. WDYT? |
I've changed the strategy and utilized |
Thanks for the initial PR and your patience 🙏. I think we now have a good approach that should work for new releases (and different MSSQL versions) right out of the box. |
What does this PR do?
It adds a check on the mssql-tools path which changed during 2022-CU14 update.
Why is it important?
Because from the 2022-CU14 version, Microsoft changed the path to the mssql tools, breaking CI for many folks who have been using the 2022-latest image tag.
Related issues
Follow-ups
I'm not a fan of duplicating the logic between WaitUntil and the MsSqlContainer :'(