Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MySql): Create an empty /var/lib/mysql-files directory to prevent older versions from failing to start #1144

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Mar 23, 2024

What does this PR do?

This pull request creates an empty /var/lib/mysql-files directory for MySql containers. This directory is required for MySql containers to properly start. The /var/lib/mysql-files directory exists for mysql:8.0.29 images onwards but does not exist for mysql:8.0.28 and earlier images.

Why is it important?

This fixes a regression introduced in Testcontainers.MySql 3.8.0

Related issues

Fixes #1142

Copy link

netlify bot commented Mar 23, 2024

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 3394090
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/6601992089e7580008374d33
😎 Deploy Preview https://deploy-preview-1144--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@0xced 0xced force-pushed the fix-mysql-8.0.28 branch from 5b6b2df to 180a9dc Compare March 23, 2024 15:07
@HofmeisterAn HofmeisterAn added the bug Something isn't working label Mar 25, 2024
@HofmeisterAn HofmeisterAn changed the title fix: Create an empty /var/lib/mysql-files directory for the MySql container fix(MySql): Create an empty /var/lib/mysql-files directory to prevent older versions from failing to start Mar 25, 2024
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ✌️.

@HofmeisterAn HofmeisterAn merged commit 533a249 into testcontainers:develop Mar 25, 2024
11 checks passed
@0xced 0xced deleted the fix-mysql-8.0.28 branch March 25, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: MySQL 8.0.28 Container Fails to Start with Testcontainers 3.8.0
2 participants