Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove Sonar findings; update PR template #1069

Merged
merged 1 commit into from
Dec 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
<!-- Type of change
Please label this PR with one of the existing labels, depending on the scope of your change.
-->

## What does this PR do?

<!-- Mandatory
Expand Down
1 change: 0 additions & 1 deletion Packages.props
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>
<ItemGroup>
<GlobalPackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="6.0.0" />
<PackageReference Update="Docker.DotNet" Version="3.125.15" />
<PackageReference Update="Docker.DotNet.X509" Version="3.125.15" />
<PackageReference Update="Microsoft.Bcl.AsyncInterfaces" Version="6.0.0" />
Expand Down
2 changes: 1 addition & 1 deletion build.cake
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#tool nuget:?package=dotnet-sonarscanner&version=5.14.0
#tool nuget:?package=dotnet-sonarscanner&version=5.15.0

#addin nuget:?package=Cake.Sonar&version=1.1.32

Expand Down
1 change: 0 additions & 1 deletion src/Testcontainers.ActiveMq/Usings.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
global using System;
global using System.Threading.Tasks;
global using Docker.DotNet.Models;
global using DotNet.Testcontainers;
global using DotNet.Testcontainers.Builders;
Expand Down
2 changes: 1 addition & 1 deletion src/Testcontainers.Couchbase/CouchbaseBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,7 @@ await Task.Delay(TimeSpan.FromSeconds(1), cancellationToken)
}
}

throw new Exception($"Unable to configure Couchbase. The HTTP request '{request.RequestUri}' did not complete successfully.");
throw new HttpRequestException($"Unable to configure Couchbase. The HTTP request '{request.RequestUri}' did not complete successfully.");
}
}
}
1 change: 0 additions & 1 deletion src/Testcontainers.RabbitMq/Usings.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
global using System;
global using System.Threading.Tasks;
global using Docker.DotNet.Models;
global using DotNet.Testcontainers;
global using DotNet.Testcontainers.Builders;
Expand Down
1 change: 0 additions & 1 deletion src/Testcontainers.RavenDb/Usings.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
global using System;
global using System.Threading.Tasks;
global using Docker.DotNet.Models;
global using DotNet.Testcontainers.Builders;
global using DotNet.Testcontainers.Configurations;
Expand Down
1 change: 0 additions & 1 deletion src/Testcontainers.SqlEdge/Usings.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
global using System.Collections.Generic;
global using System.Linq;
global using System.Threading.Tasks;
global using Docker.DotNet.Models;
global using DotNet.Testcontainers;
global using DotNet.Testcontainers.Builders;
Expand Down
3 changes: 1 addition & 2 deletions src/Testcontainers/Images/DockerImage.cs
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@ public DockerImage(
.Where(imageComponent => !string.IsNullOrEmpty(imageComponent))
.DefaultIfEmpty(string.Empty)
.First()
.Split('/')
.First();
.Split('/')[0];

if (firstSegmentOfRepository.IndexOfAny(new[] { '.', ':' }) >= 0)
{
Expand Down