Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for credential helpers for custom registries #461

Closed
harrhp opened this issue May 27, 2022 · 3 comments
Closed

Add support for credential helpers for custom registries #461

harrhp opened this issue May 27, 2022 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@harrhp
Copy link

harrhp commented May 27, 2022

Is your feature request related to a problem? Please describe.
I need a way to authenticate to private registry via credential helper when pulling images. I have 2 private registries in ~/docker/.config.json that use bat files to provide credential. I don't know credentials in advance to just do docker login so i need to use helpers. Right now i can't pull images with this setup

Describe the solution you'd like
I think there should be another implementation of IAuthenticationProvider that implements credential helpers protocol described in the link below

Describe alternatives you've considered
i didn't find any solution

Additional context
https://docs.docker.com/engine/reference/commandline/login/#credential-helpers
I use version 1.6.0-beta.2226

@HofmeisterAn
Copy link
Collaborator

I added the class CredsHelperProvider in advance:

https://github.com/HofmeisterAn/dotnet-testcontainers/blob/ba7d87befb0ece496d94ec9f350d503a264a372c/src/DotNet.Testcontainers/Builders/CredsHelperProvider.cs#L6-L19

But I don't know exactly how the credential helpers work. I haven't looked into the docs, etc. Maybe, someone else can add the implementation. Or I need to do some researches first.

@HofmeisterAn HofmeisterAn added enhancement New feature or request help wanted Extra attention is needed labels May 28, 2022
@HofmeisterAn HofmeisterAn added this to the 1.6.0 milestone May 28, 2022
@HofmeisterAn HofmeisterAn modified the milestones: 1.6.0, 1.7.0 Jun 7, 2022
HofmeisterAn pushed a commit that referenced this issue Jun 16, 2022
…kerRegistryAuthenticationProvider'

{add credential helpers support}
@HofmeisterAn HofmeisterAn added RFD and removed help wanted Extra attention is needed labels Jun 16, 2022
@HofmeisterAn
Copy link
Collaborator

We'll publish this change as soon as we update the NuGet feed configuration.

@HofmeisterAn HofmeisterAn removed the RFD label Jun 20, 2022
@HofmeisterAn
Copy link
Collaborator

Published in 1.7.0-beta.2530372824.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants