fix: multiple filters #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenh
force-pushed
the
fix/multiple-filters
branch
from
bbd072a
to
3b148ac
Compare
stevenh
force-pushed
the
fix/multiple-filters
branch
from
3b148ac
to
6d74436
Compare
stevenh
force-pushed
the
fix/multiple-filters
branch
2 times, most recently
from
a014101
to
fa3872d
Compare
mdelapenya
reviewed
Oct 22, 2024
mdelapenya
previously approved these changes
Oct 22, 2024
stevenh
force-pushed
the
fix/multiple-filters
branch
from
fa3872d
to
a1ad992
Compare
mdelapenya
previously approved these changes
Oct 22, 2024
stevenh
force-pushed
the
fix/multiple-filters
branch
from
a1ad992
to
310563f
Compare
mdelapenya
previously approved these changes
Oct 23, 2024
stevenh
force-pushed
the
fix/multiple-filters
branch
from
310563f
to
ecfe940
Compare
Fix multiple filters which was only applying the removal of the last iterated set. Add tests to validate that: * Multiple filters are correctly processed * Duplicate filters are correctly ignored * Immediate shutdown occurs if no clients This increasing code coverage to 89.4%. Use best effort in removal if resource changes are detected after a shutdown has been signalled to allow as much to be cleaned up as possible. This includes a new setting ChangesRetryInterval exposed by the env variable RYUK_CHANGES_RETRY_INTERVAL and defaults to 1 second which is used to control the interval between retries if resource changes are detected.
stevenh
force-pushed
the
fix/multiple-filters
branch
from
ecfe940
to
37c3a18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix multiple filters which was only applying the removal of the last iterated set.
Add tests to validate that:
This increasing code coverage to 89.4%.
Use best effort in removal if resource changes are detected after a shutdown has been signalled to allow as much to be cleaned up as possible.
This includes a new setting
ChangesRetryIntervalexposed by the env variableRYUK_CHANGES_RETRY_INTERVALand defaults to 1 second which is used to control the interval between retries if resource changes are detected.