fix: timeout and shutdown #121
Conversation
Fix waitForPruneCondition timeout handling which was not resetting the connection timeout when new connections came in resulting in the reaper shutting down incorrectly. Don't log EOF errors. Add buffer to connection channels so we don't block the accepting goroutine. Fixes testcontainers/testcontainers-go#2348
|
@mdelapenya any chance you can help get this one across the line, as its causing random failures in testcontainers-go? |
Thanks for that, most appreciated! To get this one fully put to bed, what's the release process, as we'll need to a PR against testcontainers-go to bump it to the new version to get this fix? |
|
Exactly, I'm planning to create a release of Ryuk soon this week, the 0.7.1 |
|
Just checking in on the release @mdelapenya to make sure it doesn't slip though 😃 |
|
Hey @mdelapenya just checking in on this, as we're seeing constant test failures on very basic setups due to this, so would really appreciate a new release here and then one for testcontainers-go with the updated image. If there's anything I can do assist let me know. |
|
We are hitting this bug as well, and I was planning on fixing it this weekend, but happy to see @stevenh beat me to it. For posterity:
|
Fix
waitForPruneConditiontimeout handling which was not resetting the connection timeout when new connections came in resulting in the reaper shutting down incorrectly.Don't log
EOFerrors.Add buffer to connection channels so we don't block the accepting goroutine.
Fixes testcontainers/testcontainers-go#2348