-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mirror] SQL MI Manual and Scheduled Start/Stop APIs #2753
[Mirror] SQL MI Manual and Scheduled Start/Stop APIs #2753
Conversation
Hi, @ruowan Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
ManagedEnvironments.json | 2022-01-01-preview(d413808) | 2022-01-01-preview(main) |
ManagedEnvironments.json | 2022-06-01-preview(d413808) | 2022-06-01-preview(main) |
ManagedEnvironments.json | 2022-11-01-preview(d413808) | 2022-11-01-preview(main) |
ManagedEnvironments.json | 2022-03-01(d413808) | 2022-03-01(main) |
ManagedEnvironments.json | 2022-10-01(d413808) | 2022-10-01(main) |
appplatform.json | 2023-03-01-preview(d413808) | 2023-03-01-preview(main) |
communicationserviceschat.json | 2023-07-01-preview(d413808) | 2023-07-01-preview(main) |
datafactory.json | 2018-06-01(d413808) | 2018-06-01(main) |
search.json | 2022-12-01-preview(d413808) | 2022-12-01-preview(main) |
Capabilities.json | 2023-03-01-preview(d413808) | 2023-03-01-preview(main) |
FlexibleServers.json | 2023-03-01-preview(d413808) | 2023-03-01-preview(main) |
Migrations.json | 2023-03-01-preview(d413808) | 2023-03-01-preview(main) |
FlexibleServers.json | 2022-12-01(d413808) | 2022-12-01(main) |
postgresqlhsc.json | 2022-11-08(d413808) | 2022-11-08(main) |
quantum.json | 2022-09-12-preview(d413808) | 2022-09-12-preview(main) |
deploymentStacks.json | 2022-08-01-preview(d413808) | 2022-08-01-preview(main) |
TrafficController.json | 2023-05-01-preview(d413808) | 2023-05-01-preview(main) |
DatabaseOperations.json | 2022-08-01-preview(d413808) | 2022-08-01-preview(main) |
DatabaseUsages.json | 2022-08-01-preview(d413808) | 2022-08-01-preview(main) |
Databases.json | 2022-08-01-preview(d413808) | 2022-08-01-preview(main) |
DistributedAvailabilityGroups.json | 2022-08-01-preview(d413808) | 2022-08-01-preview(main) |
FailoverGroups.json | 2022-08-01-preview(d413808) | 2022-08-01-preview(main) |
InstanceFailoverGroups.json | 2022-08-01-preview(d413808) | 2022-08-01-preview(main) |
ManagedDatabaseMoveOperations.json | 2022-08-01-preview(d413808) | 2022-08-01-preview(main) |
ManagedDatabases.json | 2022-08-01-preview(d413808) | 2022-08-01-preview(main) |
ReplicationLinks.json | 2022-08-01-preview(d413808) | 2022-08-01-preview(main) |
FailoverGroups.json | 2022-11-01-preview(d413808) | 2022-11-01-preview(main) |
IPv6FirewallRules.json | 2022-11-01-preview(d413808) | 2022-11-01-preview(main) |
privatelinkhub.json | 2021-06-01(d413808) | 2021-06-01(main) |
sqlServer.json | 2021-06-01(d413808) | 2021-06-01(main) |
ChangeDataCapture.json | 2018-06-01(d413808) | 2018-06-01(main) |
Only 1 items are listed, please refer to log for more details.
Rule | Message |
---|---|
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'IPv6 FirewallRule' removed or renamed? New: Microsoft.Sql/preview/2022-11-01-preview/IPv6FirewallRules.json#L214:3 Old: Microsoft.Sql/preview/2022-11-01-preview/IPv6FirewallRules.json#L214:3 |
️❌
Breaking Change(Cross-Version): 131 Errors, 187 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
AuthConfigs.json | 2023-04-01-preview(d413808) | 2022-10-01(main) |
AuthConfigs.json | 2023-04-01-preview(d413808) | 2022-11-01-preview(main) |
AvailableWorkloadProfiles.json | 2023-04-01-preview(d413808) | 2022-10-01(main) |
AvailableWorkloadProfiles.json | 2023-04-01-preview(d413808) | 2022-11-01-preview(main) |
BillingMeters.json | 2023-04-01-preview(d413808) | 2022-10-01(main) |
BillingMeters.json | 2023-04-01-preview(d413808) | 2022-11-01-preview(main) |
CommonDefinitions.json | 2023-04-01-preview(d413808) | 2022-10-01(main) |
CommonDefinitions.json | 2023-04-01-preview(d413808) | 2022-11-01-preview(main) |
ConnectedEnvironments.json | 2023-04-01-preview(d413808) | 2022-10-01(main) |
ConnectedEnvironments.json | 2023-04-01-preview(d413808) | 2022-11-01-preview(main) |
ConnectedEnvironmentsCertificates.json | 2023-04-01-preview(d413808) | 2022-10-01(main) |
ConnectedEnvironmentsCertificates.json | 2023-04-01-preview(d413808) | 2022-11-01-preview(main) |
ConnectedEnvironmentsDaprComponents.json | 2023-04-01-preview(d413808) | 2022-10-01(main) |
ConnectedEnvironmentsDaprComponents.json | 2023-04-01-preview(d413808) | 2022-11-01-preview(main) |
ConnectedEnvironmentsStorages.json | 2023-04-01-preview(d413808) | 2022-10-01(main) |
ConnectedEnvironmentsStorages.json | 2023-04-01-preview(d413808) | 2022-11-01-preview(main) |
ContainerApps.json | 2023-04-01-preview(d413808) | 2022-10-01(main) |
ContainerApps.json | 2023-04-01-preview(d413808) | 2022-11-01-preview(main) |
ContainerAppsRevisions.json | 2023-04-01-preview(d413808) | 2022-10-01(main) |
ContainerAppsRevisions.json | 2023-04-01-preview(d413808) | 2022-11-01-preview(main) |
Diagnostics.json | 2023-04-01-preview(d413808) | 2022-10-01(main) |
Diagnostics.json | 2023-04-01-preview(d413808) | 2022-11-01-preview(main) |
Global.json | 2023-04-01-preview(d413808) | 2022-10-01(main) |
Global.json | 2023-04-01-preview(d413808) | 2022-11-01-preview(main) |
ManagedEnvironments.json | 2023-04-01-preview(d413808) | 2022-10-01(main) |
ManagedEnvironments.json | 2023-04-01-preview(d413808) | 2022-11-01-preview(main) |
ManagedEnvironmentsDaprComponents.json | 2023-04-01-preview(d413808) | 2022-10-01(main) |
ManagedEnvironmentsDaprComponents.json | 2023-04-01-preview(d413808) | 2022-11-01-preview(main) |
ManagedEnvironmentsStorages.json | 2023-04-01-preview(d413808) | 2022-10-01(main) |
ManagedEnvironmentsStorages.json | 2023-04-01-preview(d413808) | 2022-11-01-preview(main) |
SourceControls.json | 2023-04-01-preview(d413808) | 2022-10-01(main) |
SourceControls.json | 2023-04-01-preview(d413808) | 2022-11-01-preview(main) |
appplatform.json | 2023-05-01-preview(d413808) | 2022-12-01(main) |
appplatform.json | 2023-05-01-preview(d413808) | 2023-03-01-preview(main) |
arcSettings.json | 2022-12-15-preview(d413808) | 2022-12-01(main) |
arcSettings.json | 2022-12-15-preview(d413808) | 2021-09-01-preview(main) |
clusters.json | 2022-12-15-preview(d413808) | 2022-12-01(main) |
clusters.json | 2022-12-15-preview(d413808) | 2021-09-01-preview(main) |
common.json | 2022-12-15-preview(d413808) | 2021-09-01-preview(main) |
extensions.json | 2022-12-15-preview(d413808) | 2022-12-01(main) |
extensions.json | 2022-12-15-preview(d413808) | 2021-09-01-preview(main) |
galleryImages.json | 2022-12-15-preview(d413808) | 2021-09-01-preview(main) |
marketplaceGalleryImages.json | 2022-12-15-preview(d413808) | 2021-09-01-preview(main) |
networkInterfaces.json | 2022-12-15-preview(d413808) | 2021-09-01-preview(main) |
offers.json | 2022-12-15-preview(d413808) | 2022-12-01(main) |
operations.json | 2022-12-15-preview(d413808) | 2022-12-01(main) |
operations.json | 2022-12-15-preview(d413808) | 2021-09-01-preview(main) |
publishers.json | 2022-12-15-preview(d413808) | 2022-12-01(main) |
skus.json | 2022-12-15-preview(d413808) | 2022-12-01(main) |
storageContainers.json | 2022-12-15-preview(d413808) | 2021-09-01-preview(main) |
updateRuns.json | 2022-12-15-preview(d413808) | 2022-12-01(main) |
updateSummaries.json | 2022-12-15-preview(d413808) | 2022-12-01(main) |
updates.json | 2022-12-15-preview(d413808) | 2022-12-01(main) |
virtualHardDisks.json | 2022-12-15-preview(d413808) | 2021-09-01-preview(main) |
virtualMachines.json | 2022-12-15-preview(d413808) | 2021-09-01-preview(main) |
virtualNetworks.json | 2022-12-15-preview(d413808) | 2021-09-01-preview(main) |
afdx.json | 2023-05-01(d413808) | 2021-06-01(main) |
afdx.json | 2023-05-01(d413808) | 2022-11-01-preview(main) |
cdn.json | 2023-05-01(d413808) | 2021-06-01(main) |
cdn.json | 2023-05-01(d413808) | 2022-11-01-preview(main) |
cdnwebapplicationfirewall.json | 2023-05-01(d413808) | 2021-06-01(main) |
cdnwebapplicationfirewall.json | 2023-05-01(d413808) | 2022-11-01-preview(main) |
communicationservicescallautomation.json | 2023-03-06(d413808) | 2022-04-07-preview(main) |
CommunicationServices.json | 2023-04-01-preview(d413808) | 2023-03-31(main) |
CommunicationServices.json | 2023-04-01-preview(d413808) | 2023-03-01-preview(main) |
Domains.json | 2023-04-01-preview(d413808) | 2023-03-31(main) |
Domains.json | 2023-04-01-preview(d413808) | 2023-03-01-preview(main) |
EmailServices.json | 2023-04-01-preview(d413808) | 2023-03-31(main) |
EmailServices.json | 2023-04-01-preview(d413808) | 2023-03-01-preview(main) |
SenderUsernames.json | 2023-04-01-preview(d413808) | 2023-03-31(main) |
SenderUsernames.json | 2023-04-01-preview(d413808) | 2023-03-01-preview(main) |
elastic.json | 2023-06-01(d413808) | 2020-07-01(main) |
elastic.json | 2023-06-01(d413808) | 2023-05-01-preview(main) |
graphservicesprod.json | 2023-04-13(d413808) | 2022-09-22-preview(main) |
registeredidentities.json | 2023-04-01(d413808) | 2023-02-01(main) |
registeredidentities.json | 2023-04-01(d413808) | 2022-09-30-preview(main) |
replicationusages.json | 2023-04-01(d413808) | 2023-02-01(main) |
replicationusages.json | 2023-04-01(d413808) | 2022-09-30-preview(main) |
vaults.json | 2023-04-01(d413808) | 2023-02-01(main) |
vaults.json | 2023-04-01(d413808) | 2022-09-30-preview(main) |
vaultusages.json | 2023-04-01(d413808) | 2023-02-01(main) |
vaultusages.json | 2023-04-01(d413808) | 2022-09-30-preview(main) |
healthReports.json | 2023-05-01-preview(d413808) | 2023-02-01-preview(main) |
trafficmanager.json | 2022-04-01(d413808) | 2018-08-01(main) |
trafficmanager.json | 2022-04-01(d413808) | 2022-04-01-preview(main) |
voiceservices.json | 2023-04-03(d413808) | 2023-01-31(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 1 items are listed, please refer to log for more details.
Rule | Message |
---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.App/connectedEnvironments/{connectedEnvironmentName}' removed or restructured? Old: Microsoft.App/stable/2022-10-01/ConnectedEnvironments.json#L100:5 |
The following breaking changes are detected by comparison with latest preview version:
Only 1 items are listed, please refer to log for more details.
Rule | Message |
---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/galleryimages/{galleryimagesName}' removed or restructured? Old: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L40:5 |
️🔄
LintDiff inProgress [Detail]
️️✔️
~[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
Validation passes for ServiceAPIReadinessTest.
️❌
SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️❌
CadlAPIView: 0 Errors, 1 Warnings failed [Detail]
Rule | Message |
---|---|
"How to fix":"Check the detailed log and update cadl version to latest." |
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌
Avocado: 5 Errors, 8 Warnings failed [Detail]
Only 1 items are listed, please refer to log for more details.
Rule | Message |
---|---|
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Cdn/CdnWebApplicationFirewallPolicies is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/cdn/resource-manager/readme.md json: Microsoft.Cdn/stable/2020-09-01/cdnwebapplicationfirewall.json |
️❌
ModelValidation: 146 Errors, 0 Warnings failed [Detail]
Only 1 items are listed, please refer to log for more details.
Rule | Message |
---|---|
MISSING_RESOURCE_ID |
id is required to return in response of GET/PUT resource calls but not being provided Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5324:36 ExampleUrl: stable/2023-05-01/examples/Endpoints_ListByProfile.json#L30:33 |
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
~[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
~[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️❌
PR Summary: 0 Errors, 0 Warnings failed [Detail]
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
TypeSpec Validation succeeded [Detail]
Only 1 items are listed, please refer to log for more details.
Rule | Message |
---|---|
InConsistentSwagger |
"details":"The generated swagger file 2023-05-01-preview/TrafficController.json from typespec specification/servicenetworking/ServiceNetworking.Management is not the same as the '/mnt/vss/_work/1/azure-rest-api-specs/specification/servicenetworking/resource-manager/Microsoft.ServiceNetworking/preview/2023-05-01-preview/TrafficController.json' in PR, please make sure the swagger is consistent with the generated swagger. You can find the difference in the pipeline log." |
Swagger Generation Artifacts
|
Generated ApiView
|
Hi @ruowan, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Hi @ruowan, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi, @ruowan, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
/azp run |
No pipelines are associated with this pull request. |
/azp run |
No pipelines are associated with this pull request. |
6f00025
to
9184dcd
Compare
Mirror from
https://github.com/Azure/azure-rest-api-specs/pull/21376