Hyper-v Name Length fix #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of b018a07 to introduce unique names a uuid was added to the generated vagrantfile. This causes problems with hyper-v which relies on names being 100 characters or less otherwise it throws an exception. This commit takes the current naming system and substrings it to fit within this character limit. It may be a better idea to use time ticks as these would end up with us substringing less due to their shorter nature (the UUID is a third of the allowed length by itself) 1.5.2 2.2.5 2.2.5 Windows 10 Signed-off-by: Xorima <[email protected]>
Closed
|
|
|
Thanks @xorima |
|
When will this be released? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of b018a07 to introduce unique names a uuid was added to the generated vagrantfile. This causes problems with hyper-v which relies on names being 100 characters or less otherwise it throws an exception.
This commit takes the current naming system and substrings it to fit within this character limit. It may be a better idea to use time ticks as these would end up with us substringing less due to their shorter nature (the UUID is a third of the allowed length by itself)
Kitchen-Vagrant Version
1.5.2
Test-Kitchen Version
2.2.5
Vagrant Version
2.2.5
Host Operating System
Windows 10
Issues Resolved:
#403