disable audio in virtualbox by default #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #388 As mentioned in that issue, modifying the VM to have audio set to "none" will disable sound for the VM and prevent VirtualBox from connecting to the host's audio which really cramps a user's style when they're listening to something over bluetooth headphones. This change opts to be simple-but-repetitive in the tests to include the new default in each example VM config. Signed-off-by: Robb Kidd <[email protected]>
Fixnum was deprecated in Ruby 2.4, so this should be checking for Integer. Changed this check to `kind_of?` for backwards compatibility. Fixnum is a subclass of Integer, even in Ruby < 2.4. `kind_of?` will return true if the class given is the class of the object, or if it is one of the superclasses of the object or modules included in the object. `instance_of?` only returns true for an exact match on the class, does not take subclassing into consideration. Signed-off-by: Robb Kidd <[email protected]>
cheeseplus
approved these changes
Jan 28, 2019
tyler-ball
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #388
As mentioned in that issue, modifying the VM to have audio set to "none" will disable sound for the VM and prevent VirtualBox from connecting to the host's audio which really cramps a user's style when they're listening to something over bluetooth headphones.
This change opts to be simple-but-repetitive in the tests to include the new default in each example VM config.
Also resolves a deprecation notice about the use of
Fixnum.