Adding a per-instance generated vmname for Hyper-V #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #367
This PR allows a VM instance created by kitchen-vagrant and the Hyper-V provider to be identified by its instance name. This makes it easier to identify the running VM when looking at the Hyper-V running configuration (either via UI or PowerShell).
The actual hostname (Linux) or NetBIOS name of the machine (if Windows) is not affected by this change, it only affects the display name in Hyper-V manager.
Given a base folder name of hypervtest, a default suite and a platform named windows2012r2, the generated name is as follows:
kitchen-hypervtest-default-windows2012r2Signed-off-by: Stuart Preston [email protected]