revert parallelism for Virtualbox #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9691e9b. Signed-off-by: Robb Kidd <[email protected]>
This reverts commit 90b3c84. Signed-off-by: Robb Kidd <[email protected]>
This reverts commit a946fb6. Signed-off-by: Robb Kidd <[email protected]>
cheeseplus
approved these changes
Aug 22, 2017
cheeseplus
approved these changes
Aug 22, 2017
Merged
|
Thanks for reverting this. I had my "VirtualBox VMs" folder mounted on an SSD and it took me ages to figure out why it wasn't writing there any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change exacerbated an existing path-too-long problem in Windows [#210] and introduced a few new undesired behaviors as default. (#322, kitchen VMs running entirely disconnected from the Virtualbox manager, and
gui: trueno longer working.)Reverting in favor of working a future PR for Virtualbox parallelism as optional. (Which is tricky given that we'll need to tinker with
@serial_actionswithout usingno_parallel_for.)