shorten the directory name for vagrant_root #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheeseplus
approved these changes
Aug 22, 2017
This omits "kitchen-#{something}" from the vagrant root directories that
will appear under .kitchen/kitchen-vagrant.
Windows users will run into a path length limit of 260 characters.[1]
We have been repeating in the directory structure "kitchen-" and the
basename of kitchen-root--the directory that contains the .kitchen.yml
which most of the time works out to be the name of the cookbook being
tested. This made for meaningful if verbose names for virtual machines
so as to correlate a machine running in a Vagrant-supported hypervisor
to a test-kitchen config.
The inclusion of this string was _not_ for any unique identifier to
avoid naming collusions within the hypervisor. This change should be
safe for an upgrade for kitchens that have running instances prior to
upgrade. The state file for a machine that was successfully created will
have recorded the vagrant_root path used at creation time. This will
allow kitchen commands to continue to operate on the running instances.
[1] #210
Signed-off-by: Robb Kidd <[email protected]>
robbkidd
force-pushed
the
robb/a-shorter-vagrant-root
branch
from
a9e354a to
1f58fce
Compare
|
Cleanly rebased to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This omits "kitchen-#{something}" from the vagrant root directories that will appear under .kitchen/kitchen-vagrant.
Windows users will run into a path length limit of 260 characters. We have been repeating in the directory structure "kitchen-" and the basename of kitchen-root--the directory that contains the .kitchen.yml which most of the time works out to be the name of the cookbook being tested. This made for meaningful if verbose names for virtual machines so as to correlate a machine running in a Vagrant-supported hypervisor to a test-kitchen config.
The inclusion of this string was not for any unique identifier to avoid naming collusions within the hypervisor. This change should be safe for an upgrade for kitchens that have running instances prior to upgrade. The state file for a machine that was successfully created will have recorded the vagrant_root path used at creation time. This will allow kitchen commands to continue to operate on the running instances.
Fixes #210