Fix detection of vagrant-winrm plugin. #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to some Windows shell vagaries, exact line regex matching on vagrant-winrm plugin is failing. Loosening up the regex just a little bit allows it to succeed. There's a very low probability of matching the wrong vagrant plugin, but it is possible I suppose. Certain Windows shells are colorizing the output of the command `vagrant plugin list`, which is causing the match failure. Wild theory, could be a change due to Windows Anniversary Update, as they've been making fundamental changes to the command shells.
cheeseplus
approved these changes
Jul 24, 2017
|
This looks good and safe enough for merge. |
This was referenced Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some Windows shell vagaries, exact line regex matching on vagrant-winrm plugin is failing. Loosening up the regex just a little bit allows it to succeed. There's a very low probability of matching the wrong vagrant plugin, but it is possible I suppose.
Certain Windows shells are colorizing the output of the command
vagrant plugin list, which is causing the match failure. Wild theory, could be a change due to Windows Anniversary Update, as they've been making fundamental changes to the command shells.