Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in Vagrantfile template related to WinRM options (missed quote) #306

Merged
merged 1 commit into from
Jul 24, 2017

Conversation

aleksey-hariton
Copy link

Setup of WinRM options breaks Kitchen, .kitchen.yml:

driver:
  name: vagrant
  winrm:
    username: Administrator
    password: password

Error:

/.../.kitchen/kitchen-vagrant/.../Vagrantfile:4: syntax error, unexpected tIDENTIFIER, expecting keyword_end

Reason: missed quote around WinRM values in Vagrantfile

@kenmacleod
Copy link

Bump. Ran into this same issue and had to quote the winrm parameters twice ('"param"') as a workaround.

@mwrock
Copy link
Member

mwrock commented May 9, 2017

My only concern is with numeric or boolean values. However, ensuring all types are dealt with correctly is a more complicated change and this clearly makes the code better since most configs will be string based and are currently broken. Even numeric values like port are ok to pass in as a string I believe since all the way down to the protocol level they are treated as such. However timeout may be different where math is performed.

@cheeseplus cheeseplus merged commit cad37e8 into test-kitchen:master Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants