Only enable the cache when using known bento boxes. Fix #296 #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seth Thomas <[email protected]>
tduffield
approved these changes
Mar 30, 2017
tas50
approved these changes
Mar 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given what we've seen it's a better assumption to only enable the
cache_directoryby default for platforms we expect will work with shared folders, namely a subset of bento boxes. This has some advantages:boxisbento/*where * is a subset of bentos boxesThis will change the default of
cache_directorybut does so in a way that minimizes frustration and maximizes delight. We're still pursuing an overall better way of caching to work around the limitations of shared folders but this should at least make the experience more pleasant out of the box.Signed-off-by: Seth Thomas [email protected]