Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to chefstyle #264

Merged
merged 3 commits into from
Dec 12, 2016
Merged

Move to chefstyle #264

merged 3 commits into from
Dec 12, 2016

Conversation

shortdudey123
Copy link
Contributor

This should also fix Travis :)

@shortdudey123
Update cane version pinning
4a91aa1 
Cleans up error:
```
rake aborted!
NoMethodError: undefined method `last_comment' for #<Rake::Application:0x007fdf50cb8590>
```
@shortdudey123
Replace finstyle with chefstyle
ed7dc61
@shortdudey123
Fix all Chefstyle offenses
84ea74a 
Fixed via `chefstyle -a`

Before
```
8 files inspected, 87 offenses detected
RuboCop failed!
```

After
```
8 files inspected, no offenses detected
```
@cheeseplus cheeseplus mentioned this pull request Dec 12, 2016
Closed
smurawski
smurawski approved these changes Dec 12, 2016
View reviewed changes
Copy link
Contributor

@smurawski smurawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smurawski smurawski merged commit 176d926 into test-kitchen:master Dec 12, 2016
@shortdudey123 shortdudey123 deleted the move_to_chefstyle branch December 12, 2016 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smurawski smurawski smurawski approved these changes

@cheeseplus cheeseplus cheeseplus approved these changes

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortdudey123 @cheeseplus @smurawski