-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not map the extra cache drive on non virtualbox windows #255
Conversation
c8688ba
to
456f2f5
Compare
1b88444
to
7dce8bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one single comment..
end | ||
|
||
super(cmd, merged) | ||
end | ||
# rubocop:enable Metrics/CyclomaticComplexity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this cop?
The threshold could certainly be bumped IMO :) But I generally like this cop. |
Tested on a Mac Host spinning up a Windows 7 Guest VM using VirtualBox:
|
…map the extra cache drive on non virtualbox windows Signed-off-by: Matt Wrock <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a quick set of tests but I know you tested it locally so I'll approve.
cc/ @test-kitchen/maintainers ^^^^^^ |
Signed-off-by: Matt Wrock <[email protected]>
…
Signed-off-by: Matt Wrock [email protected]