Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not map the extra cache drive on non virtualbox windows #255

Merged
merged 2 commits into from
Dec 5, 2016
Merged

Conversation

mwrock
Copy link
Member

@mwrock mwrock commented Dec 1, 2016


Signed-off-by: Matt Wrock [email protected]

@mwrock mwrock force-pushed the bundler-v branch 2 times, most recently from c8688ba to 456f2f5 Compare December 1, 2016 09:24
@mwrock mwrock force-pushed the bundler-v branch 2 times, most recently from 1b88444 to 7dce8bf Compare December 1, 2016 09:34
@mwrock mwrock mentioned this pull request Dec 1, 2016
Copy link

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one single comment..

end

super(cmd, merged)
end
# rubocop:enable Metrics/CyclomaticComplexity
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this cop?

@mwrock
Copy link
Member Author

mwrock commented Dec 2, 2016

The threshold could certainly be bumped IMO :) But I generally like this cop.

@afiune
Copy link

afiune commented Dec 5, 2016

Tested on a Mac Host spinning up a Windows 7 Guest VM using VirtualBox:

➜  tk-windows git:(master) kitchen setup win-windows-7
-----> Starting Kitchen (v1.15.0-dev)
-----> Creating <win-windows-7>...
       Bringing machine 'default' up with 'virtualbox' provider...
       ==> default: Importing base box 'windows-7'...
==> default: Matching MAC address for NAT networking...
       ==> default: Setting the name of the VM: kitchen-tk-windows-win-windows-7_default_1480960736628_49942
       ==> default: Clearing any previously set network interfaces...
       ==> default: Preparing network interfaces based on configuration...
           default: Adapter 1: nat
       ==> default: Forwarding ports...
           default: 3389 (guest) => 3389 (host) (adapter 1)
           default: 5985 (guest) => 5985 (host) (adapter 1)
           default: 22 (guest) => 2222 (host) (adapter 1)
           default: 5986 (guest) => 55986 (host) (adapter 1)
       ==> default: Running 'pre-boot' VM customizations...
       ==> default: Booting VM...
       ==> default: Waiting for machine to boot. This may take a few minutes...
           default: WinRM address: 127.0.0.1:5985
           default: WinRM username: vagrant
           default: WinRM execution_time_limit: PT2H
           default: WinRM transport: negotiate
       ==> default: Machine booted and ready!
       ==> default: Checking for guest additions in VM...
           default: The guest additions on this VM do not match the installed version of
           default: VirtualBox! In most cases this is fine, but in rare cases it can
           default: prevent things such as shared folders from working properly. If you see
           default: shared folder errors, please make sure the guest additions within the
           default: virtual machine match the version of VirtualBox you have installed on
           default: your host and reload your VM.
           default:
           default: Guest Additions Version: 4.3.14
           default: VirtualBox Version: 5.0
       ==> default: Mounting shared folders...
           default: /omnibus/cache => /Users/salimafiune/.kitchen/cache
       ==> default: Machine not provisioned because `--no-provision` is specified.
       [WinRM] Established

       Vagrant instance <win-windows-7> created.
       Finished creating <win-windows-7> (1m52.41s).

…map the extra cache drive on non virtualbox windows

Signed-off-by: Matt Wrock <[email protected]>
@mwrock mwrock changed the title dont alter the path during the bundler cleanup on windows and do not map the extra cache drive on non virtualbox windows do not map the extra cache drive on non virtualbox windows Dec 5, 2016
Copy link

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a quick set of tests but I know you tested it locally so I'll approve.

@afiune
Copy link

afiune commented Dec 5, 2016

cc/ @test-kitchen/maintainers ^^^^^^

Signed-off-by: Matt Wrock <[email protected]>
@afiune
Copy link

afiune commented Dec 5, 2016

@afiune afiune merged commit fb6904a into master Dec 5, 2016
@afiune afiune deleted the bundler-v branch December 5, 2016 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants