Fix cache directory on windows

[afiune]

We are going to default to C Drive since vagrant does not know about
the environament variables of the guest VM.

Closes #250

Signed-off-by: Salim Afiune [email protected]

[afiune]

cc/ @test-kitchen/maintainers

[coderanger]

Not sure why this is needed, all the install management script stuffs are run on the instance, not locally. Also these two paths aren't equivalent, if you want to use a temp folder.

[afiune]

@coderanger You are right! 😄 But the generation of the Vagrantfile is not and vagrant can't resolve $env:TEMP from the host.

[coderanger]

Hard coding C: is usually something we regret, so if it has to be static I would at least put in some way to configure it.

[cheeseplus]

I like the idea of at least making it configurable - that way we can fix the default case but also not dig ourselves a future hole.

[afiune]

Sounds good to me! I'll work on that.

…

On Wednesday, November 30, 2016, Seth Thomas ***@***.***> wrote: I like the idea of at least making it configurable - that way we can fix the default case but also not dig ourselves a future hole. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#251 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFcpfUBpzuy5gc1wuvKpUmaxoZ5-LptNks5rDaM7gaJpZM4LAX9i> .

[cheeseplus]

I think those last few commits fix up @coderanger's points and I'm a big +1

[afiune]

Last quick commit to fix the pipeline.

[afiune]

ping @coderanger ^^^

[coderanger]

I assume the simplecov stuff is because of the compat break with code-climate, the actual change looks good though 👍

[afiune]

[kernelsmith]

I actually tried this change manually and it didn't work, seems like the cache string is getting interpreted twice. I had to use c:\\omnibus\\cache otherwise it continued to present as c:omnibusche

 default: -- /Users/me/.kitchen/cache: C:omnibusche
STDERR: The following WinRM command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!

function Test-ReparsePoint([string]$path) {
  $file = Get-Item $path -Force -ea 0
  return [bool]($file.Attributes -band [IO.FileAttributes]::ReparsePoint)
}

$MountPoint = [System.IO.Path]::GetFullPath("C:omnibusche")
$ShareName = "C:omnibusche"
$VmProviderUncPath = "\\vmware-host\Shared Folders\C:omnibusche"

[kernelsmith]

also, %SYSTEMDRIVE% instead of C: may avoid future pains, tho may require some additional escaping

[afiune]

@kernelsmith Thank you for reporting your issue, we have fixed this problem and we are now in the process of releasing a new gem. If you want to try it you can always use the latest code in master this repository.