Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated Vagrantfile type issues #243

Merged
merged 1 commit into from
Sep 20, 2016
Merged

Fix generated Vagrantfile type issues #243

merged 1 commit into from
Sep 20, 2016

Conversation

jobsolete
Copy link

Adds boolean value support to ssh config option

Fixes #236
Credit: @jsirex - Original Fix

@jobsolete
Copy link
Author

Trying to narrow down where I busted the tests. Looks like possibly here?

@cheeseplus @mwrock Will you let me know if I'm on track here? Will try to get the tests updated over the next few days if so.

@mwrock
Copy link
Member

mwrock commented Sep 20, 2016

oh its not you at all. I just merged a PR that should fix tests. Just rebase your pr onto that and it should turn green.

@mwrock
Copy link
Member

mwrock commented Sep 20, 2016

👍

Adds boolean value support to ssh config option

Fixes #236
Credit: @jsirex - [Original Fix](#236 (comment))
@jobsolete
Copy link
Author

🤘 Rockin'! Looks like we're in business.

@cheeseplus
Copy link
Contributor

+1

@mwrock mwrock merged commit a3fdf32 into test-kitchen:master Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants