Allow multiple "include" statements in LXC configuration #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LXC configuration allows for including files with common settings (see
`lxc.container.conf(5)`). This is `lxc.include` directive differs
from other settings, in that multiple settings of the same key makes
sense. Previously, a configuration of the form:
driver:
name: vagrant
provider: lxc
customize:
include: '/usr/share/lxc/config/ubuntu.common.conf'
include: '/usr/share/lxc/config/nesting.conf'
...would necessarily only include one of the files, as duplicate keys
are collapsed during YAML loading. Since the existing code assumes
that all values are scalar, it was likewise impossible to set
`include` to an array.
Extend the supported syntax to allow:
driver:
name: vagrant
provider: lxc
customize:
include:
- '/usr/share/lxc/config/ubuntu.common.conf'
- '/usr/share/lxc/config/nesting.conf'
...which produces an LXC configuration of:
lxc.include=/usr/share/lxc/config/ubuntu.common.conf
lxc.include=/usr/share/lxc/config/nesting.conf
|
ping? |
|
This looks good to me! |
cheeseplus
approved these changes
Jan 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LXC configuration allows for including files with common settings (see
lxc.container.conf(5)). This islxc.includedirective differsfrom other settings, in that multiple settings of the same key makes
sense. Previously, a configuration of the form:
...would necessarily only include one of the files, as duplicate keys
are collapsed during YAML loading. Since the existing code assumes
that all values are scalar, it was likewise impossible to set
includeto an array.Extend the supported syntax to allow:
...which produces an LXC configuration of: