Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallels: Use "memory" and "cpus" customization shortcuts #194

Merged
merged 2 commits into from
Jan 16, 2016

Conversation

legal90
Copy link
Contributor

@legal90 legal90 commented Sep 3, 2015

memory and cpus customization parameters are widely used in .kitchen.yml of different community cookbooks.
But currently it doesn't work for "parallels" provider, because prlctl set command doesn't support "memory" argument (it expects to get a "memsize" instead).

However, this provider actually supports memory and cpus as customization shortcuts (it was implemented for similarity with virtualbox provider):

config.vm.provider "parallels" do |prl|
  prl.memory = 1024
  prl.cpus = 2
end

So, this PR makes it possible to use memory and cpus for "parallels" provider.

cc: @fnichol

@legal90 legal90 force-pushed the parallels-shortcuts branch from 26e9f47 to 9bd3471 Compare September 3, 2015 15:52
@legal90
Copy link
Contributor Author

legal90 commented Sep 3, 2015

I've just fixed unit test and added a new test case

@cheeseplus
Copy link
Contributor

+1

cheeseplus pushed a commit that referenced this pull request Jan 16, 2016
Parallels: Use "memory" and "cpus" customization shortcuts
@cheeseplus cheeseplus merged commit 887f31e into test-kitchen:master Jan 16, 2016
@legal90 legal90 deleted the parallels-shortcuts branch January 17, 2016 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants