Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloudstack support #167

Merged

Conversation

miguelaferreira
Copy link
Contributor

I'm maintaining the vagrant-cloudstack plugin and got several request from colleagues to integrate it with kitchen.
I know that there is a kitchen-cloudstack plugin, but it lacks support for some of the features we use (e.g. not opening the firewall to 0.0.0.0/0, or customizing the user and private key to use with SSH). It also seems a bit of double work to implement two clients, one for vagrant and another for kitchen, when kitchen can leverage vagrant. Hence, this PR.

I did not update the README file, but I will be happy to do that if requested.

@miguelaferreira
Copy link
Contributor Author

Some of the lines in the spec test are over the 80 chars limit. That's because the generated vagrant config has long lines due to complex config elements.
Can anyone suggest a way to break those lines without breaking the test?

@miguelaferreira
Copy link
Contributor Author

I broke the lines that were too long, and kept the tests passing by removing the extra new line chars. I think the tests are harder to read because of that, but given the style/formatting constrains checked in the CI build that was the only way to make it pass.

@miguelaferreira miguelaferreira force-pushed the add-cloudstack-support branch 2 times, most recently from 5079200 to 7e130c5 Compare September 7, 2015 08:45
@miguelaferreira
Copy link
Contributor Author

ping @fnichol

I've rebased this PR on current master. All checks seem good.

The underlying vagrant-cloudstack plugin is being actively maintained and tested (see https://github.com/schubergphilis/vagrant-cloudstack).
I would be willing to provide a Cloudstack test environment if anyone wants to test this PR.

@bheuvel
Copy link
Contributor

bheuvel commented Sep 15, 2015

@fnichol / @mwrock , any chance you can have a look at this?

@smurawski
Copy link
Contributor

👍 Looks good to me.

@ksubrama
Copy link

👍

@@ -124,6 +124,12 @@ Vagrant.configure("2") do |c|
<% else %>
p.<%= key %> = <%= value%>
<% end %>
<% when "cloudstack" %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is the exact same contents as openstack, can you use <% when "openstack", "cloudstack" %> instead so we don't duplicate so much?

@miguelaferreira
Copy link
Contributor Author

@tyler-ball I've made the change you've suggested.

tyler-ball added a commit that referenced this pull request Sep 23, 2015
@tyler-ball tyler-ball merged commit fc35d02 into test-kitchen:master Sep 23, 2015
@bheuvel bheuvel mentioned this pull request Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants