Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config[:ssh] to be quoted properly #163

Merged
merged 2 commits into from
May 28, 2015

Conversation

zuazo
Copy link
Contributor

@zuazo zuazo commented Apr 22, 2015

With the this small fix, the following example will work as expected:

driver:
  ssh:
    shell: 'sh'

Related to: #131, bf38f94

@fnichol
Copy link
Contributor

fnichol commented May 7, 2015

Looks good, but the change is causing a test to fail. Think you could update the spec(s) to pass?

@zuazo
Copy link
Contributor Author

zuazo commented May 7, 2015

Sorry @fnichol, my fault 😟 Unit tests fixed.

tyler-ball added a commit that referenced this pull request May 28, 2015
Fix config[:ssh] to be quoted properly
@tyler-ball tyler-ball merged commit e8d316b into test-kitchen:master May 28, 2015
@tam7t
Copy link

tam7t commented Oct 30, 2015

This change breaks the

---
driver:
  name: vagrant
  require_chef_omnibus: true
  ssh:
    insert_key: false

workflow since the output becomes:

Vagrant.configure("2") do |c|
...
  c.ssh.insert_key = "false"
...
end

instead of

Vagrant.configure("2") do |c|
...
  c.ssh.insert_key = false
...
end

@erikaheidi
Copy link

erikaheidi commented May 18, 2016

Confirming the problem reported by @tam7t . The generated Vagrantfile is using quotes for "false" which then results in the option not to be correctly handled by Vagrant. Spent a good time trying to figure out what was wrong, only getting the "Authentication failure. Retrying.." from Vagrant. After manually editing the Vagrantfile and removing the quotes, I was able to run kitchen converge.

Test Kitchen version 1.7.3
kitchen-vagrant 0.18.0

zuazo added a commit to zuazo-forks/kitchen-vagrant that referenced this pull request May 22, 2016
@zuazo
Copy link
Contributor Author

zuazo commented May 22, 2016

Sorry, guys, I had completely forgotten this issue.

I have proposed a possible solution here: #231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants