Disable vagrant-berkshelf plugin by default... #126
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ady takes care of the dependency resolution
|
I think we should just set it to false, no config option |
|
Agree, lets not encourage people to work against it :-) |
sethvargo
added a commit
that referenced
this pull request
Dec 31, 2014
Disable vagrant-berkshelf plugin by default...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...because test-kitchen itself already takes care of resolving the cookbook dependencies via
berks.This is required for situations where a user has vagrant-berkshelf installed. In this case it will automatically kick in if a Berksfile is present. In the best case it would be just double effort, but in can also cause test-kitchen to fail.
In combination with berkshelf/vagrant-berkshelf#248 this will fix the above mentioned issue in test-kitchen/test-kitchen#575
Considerations:
Vagrantfile.erbfor the sake of completeness I added a config option to re-enable vagrant-berkshelf if someone really wants that (even though I can't imagine a good use case for it)Vagrant.has_plugin('vagrant-berkshelf')guard so vagrant won't bail out if the plugin is actually not installed