Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make box_url optional #122

Closed
wants to merge 1 commit into from
Closed

Make box_url optional #122

wants to merge 1 commit into from

Conversation

ashb
Copy link
Contributor

@ashb ashb commented Oct 22, 2014

Vagrant 1.5 doesn’t need it anymore, just the name from the Vagrant cloud

Vagrant 1.5 doesn’t need it anymore, just the name from the Vagrant cloud
@ashb
Copy link
Contributor Author

ashb commented Oct 22, 2014

This seems to be failing it's tests with this error NameError: uninitialized constant LogSwitch::Mixin which appears to be caused by one of our down stream deps, Tailor: turboladen/tailor#160

@sethvargo
Copy link
Contributor

Seems reasonable to me 👍

@legal90
Copy link
Contributor

legal90 commented Nov 10, 2014

Yes, we need this too 👍
We are using our boxes for parallels provider and it fails if there is only "box" specified in kitchen.yml:

# kitchen.yml
...
platforms:
  - name: debian-7.6
    driver:
      provider: parallels
      box: parallels/debian-7.6
# Kitchen output
...
           default: Downloading: https://opscode-vm-bento.s3.amazonaws.com/vagrant/parallels/opscode_debian-7.6_chef-provisionerless.box
>>>>>> ------Exception-------
>>>>>> Class: Kitchen::ActionFailed
>>>>>> Message: Failed to complete #create action: [Expected process to exit with [0], but received '1'
---- Begin output of vagrant up --no-provision --provider=parallels ----
STDOUT: Bringing machine 'default' up with 'parallels' provider...
==> default: Box 'parallels/debian-7.6' could not be found. Attempting to find and install...
    default: Box Provider: parallels
    default: Box Version: >= 0
==> default: Adding box 'parallels/debian-7.6' (v0) for provider: parallels
    default: Downloading: https://opscode-vm-bento.s3.amazonaws.com/vagrant/parallels/opscode_debian-7.6_chef-provisionerless.box
...

So, I guess this pull request will fix that.

sethvargo added a commit that referenced this pull request Nov 10, 2014
Make box_url optional
@sethvargo
Copy link
Contributor

Merged in 63f9eef. Thanks!

@sethvargo sethvargo closed this Nov 10, 2014
@fnichol
Copy link
Contributor

fnichol commented Mar 23, 2015

I've slightly changed the semantics of this PR in #151 but I'm hopeful that the end result is very similar. The description should help explain the rationale, but now if you want to reference base boxes on Atlas, there's less configuration getting in your way.

@legal90, I took a spin with your example above and confirmed that :box_url won't be set--actually it should never be set by default for the Parallels provider as there aren't currently any hosted Parallels Bento base boxes on S3. In other words, I'm very hopeful that your .kitchen.yml files will be much less impacted 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants