Vagrant 2.1.4 breaks require, replace with load

[electriquo]

i am using vagrantfiles as follows

platforms:
    driver:
      vagrantfiles:
        - Vagrantfile_extension.rb

$ cat Vagrantfile_extension.rb
Vagrant.configure('2') do |config|
  config.vagrant.plugins = ['vagrant-disksize']
  config.disksize.size = '50GB'
end

when i execute kitchen converge, vagrant-disksize is not invoked.
i used the flowing command to launch vagrant directly with the Vagrantfile generated by kitchen.

$ VAGRANT_VAGRANTFILE=.kitchen/kitchen-vagrant/foo-ubuntu-1604/Vagrantfile vagrant up

but again, vagrant-diskzie was not invoked.
i modified the Vagrantfile generated by kitchen, and replaced require with load and then vagrant-disksize was invoked.

some more technical information

$ vagrant --version
Vagrant 2.1.4

$ bundle exec kitchen --version
Test Kitchen version 1.23.2

$ cat Gemfile.lock | grep 'kitchen-vagrant ('
    kitchen-vagrant (1.3.3)

shall i file a bug?
can someone confirm this issue?

[cheeseplus]

Based on the formatting of the snippet, the indentation is off which means YAML won't see the key in the right place.

platforms:
  driver:
    vagrantfiles:
    - Vagrantfile_extension.rb

Please try checking the indentation first, if that's still a problem we can investigate. Also, kitchen diagnose --all will show you the merged configs so you can see what values are getting set or not set.

[electriquo]

@cheeseplus:
i followed the indentation per the documentation. in both cases, that is with placing double space before the dash and without double space, kitchen diagnose shows that Vagrantfile_extension.rb is included.

there is no issue with kitchen picking up Vagrantfile_extension.rb, but the require instruction is the issue:

i modified the Vagrantfile generated by kitchen, and replaced require with load and then vagrant-disksize was invoked.

[cheeseplus]

I'm not sure when it came to be that load was required over require - it's been there like that for the last 4 years and it's not often used so not entirely surprised. I can't find much guidance here from upstream Vagrant so we could look at a PR for changing the keyword there to load

[electriquo]

@cheeseplus:
i can confirm that it used to work in the past. i noticed the problem since vagrant 2.1.4 released 3 days ago.
can you please try to reproduce and confirm whether you are experiencing the same issue?

[cheeseplus]

I will when it's not a holiday weekend.

[cheeseplus]

This seems like a change of behaviour in upstream Vagrant, I haven't found any specific notes or commits related to the issue but we can change the key as needed if it works with older versions as well.

[electriquo]

@cheeseplus: thank you for the reply. sadly, i cannot test it with old vagrant versions to check for backward compatibility. what do you advise?

[cheeseplus]

Confirmed the existing code works fine with Vagrant 2.1.2

Also confirmed that changing it to load does seem to properly load it in 2.1.4.

[electriquo]

@cheeseplus: thank you for the confirmation. will you push the code change to fix it?

[cheeseplus]

Further testing needs to happen to ensure that I don't break earlier versions by changing to load. If this is important for you then I suggest rolling back your Vagrant version until such time as we can resolve it. It's not clear yet whether this was an intentional change on the part of the Vagrant team so I don't want to wildly flip switches when it's easy enough for users to stick on 2.1.3 or below.

[electriquo]

@cheeseplus:

Pull requests are very welcome! Make sure your patches are well tested.

i would like to assist in pushing it. this is how i thought of doing it... :)
if for every vagrant version all the tests will pass (executing rake test), is it enough?

[alval5280]

FWIW I've verified this behavior as well, and have "solved" by downgrading to Vagrant 2.1.2. I would like to see s/require/load/ for kitchen-vagrant moving forward.

[electriquo]

i completed the tests against all vagrant version but i do not know whether it is enough...

[electriquo]

i see the merge of the pull request, but a new version has yet have been published to rubygems.
excuse my lame question, any idea when we will be able to enjoy your yield? :)

[cheeseplus]

I have a few other fixes that I am attempting to get in prior to release, if you desperately need this you can modify your local install files in the case of ChefDK or install the gem from source.

[electriquo]

@cheeseplus: thank you. why won't push incrementally?

[cheeseplus]

Because there are other fixes that should go in with the release. It's been 6 hours since I merged this change - please be patient.

[cheeseplus]

1.3.4 has been released to RubyGems