Customize does not support OpenStack provider

[xmik]

A Hash of customizations to a Vagrant virtual machine supports some Vagrant providers, e.g. it does not support openstack provider. Real use case: when I set in .kitchen.yml:

    driver_config:
      box:  'debian-7.5-chef-11.16.4'
      ssh_key: '~/.ssh/id_rsa'
      customize:
        keypair_name: 'my-ssh-key'

The generated Vagrantfile should contain

  c.vm.provider :openstack do |p|
      p.keypair_name = "my-ssh-key"
  end

but instead it does:

  c.vm.provider :openstack do |p|
  end

[tyler-ball]

Hey @xmik - is there a reason you're using kitchen-vagrant instead of kitchen-openstack? As you see in your PR, all of the logic for customize is driven through an ERB file which is hard to read, test and maintain. If we can avoid adding more logic to it then we will.

We don't really want to add a catch-all else statement in the ERB because its probably not going to work for everything else (as demonstrated by the variety of elements already in the case statement). We would prefer to have a openstack-specific block that could be expanded to include other providers that match the same format. But again, we don't want to expand that ERB any more if we can help it.

You can supply a custom Vagrantfile.erb that you could format with whatever you want. If your proposed change is the only change you need from the base template that Test Kitchen provides, then it may not be worth it creating your own custom Vagrantfile. But its an option - would you want to use that? You can set the path to your custom Vagrantfile.erb with

driver:
  vagrantfile_erb: /path/to/file

If you do want to continue with a PR that supports openstack, you'll have to also add test coverage for it.

[xmik]

@tyler-ball, thanks for response. I use kitchen-vagrant instead of kitchen-openstack:

• in order to avoid very long configuration in .kitchen.yml. Vagrant boxes make it possible.
• kitchen-vagrant supports Windows, kitchen-openstack does not (as indicated in Enhancement: Windows Support kitchen-openstack#45, I also tried it and it did not work for me. However, there came a PR 4 days ago to support Windows, I didn't try it yet).
• I also use docker and wanted to avoid using 3 kitchen providers (kitchen-vagrant for OpenStack Windows, kitchen-openstack for OpenStack Linux machines, kitchen-docker for docker containers).

I saw the option that I can supply a custom Vagrantfile.erb, but I didn't want to supply it in each cookbook.

It sounds reasonable to avoid catch-all else statement in Vagrantfile.erb. I'll change it to support only openstack vagrant provider and I'll add tests.