Pulling together existing PRs for windows support #150
Conversation
| $username="#{instance.transport[:username]}" | ||
| $password="#{instance.transport[:password]}" | ||
| "Creating static user: $username" >> $logfile | ||
| & net.exe user /y /add $username $password >> $logfile |
There was a problem hiding this comment.
Will this silently fail if the user already exists? Thinking about baked AMIs, etc.
There was a problem hiding this comment.
I have no idea - can I get some help from @smurawski or @afiune?
There was a problem hiding this comment.
net user will add or modify existing accounts, so this would re-set the password to whatever test-kitchen thinks it should be for that user account. This could break things if that user account was set up in application pools or something, but that just means you shouldn't run test-kitchen's transport as a user doing some other duty.
There was a problem hiding this comment.
Okay, I'm going to leave this behavior in as the default under the assumption that users won't have an image with the TK user pre-baked. If they do, they can write their own custom user data.
tyler-ball
force-pushed
the
tball/windows
branch
from
026fa81
to
a37af1d
Compare
|
LGTM 👍 |
|
|
||
| ### New Features | ||
|
|
||
| * Added support for managing Windows hosts in AWS |
There was a problem hiding this comment.
@tyler-ball could you put our usernames against these?
There was a problem hiding this comment.
Absolutely! Thanks for the reminder and all the great contributions.
There was a problem hiding this comment.
Thanks for helping to pull this together!
tyler-ball
force-pushed
the
tball/windows
branch
from
a37af1d
to
38114ae
Compare
|
Just tested. This looks good.. Thanks @tyler-ball for pushing this and make it happen (for real!) .. 😄 |
Pulling together existing PRs for windows support
Checklist of items (copied from #133)
amis.jsonStore generated admin password and pass it to RDP command when runningkitchen logincreatemethodNote: The only way I could see to store a password in the
.rdpfile is to encrypt it using a microsoft-only DLLDepends on test-kitchen/test-kitchen#736
Replaces #96
Replaces #133
Includes #134
\cc @fnichol @zl4bv