-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch WASM engine to wasmtime #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed Wasmex.store(), added test for stdin->stdout echo
tessi
added a commit
that referenced
this pull request
Jan 3, 2023
* copy over work from https://github.com/tessi/wasmex-wasmtime * cargo fmt * update CI, drop elixir 1.11 support, add elixir 1.14 support * do not test OTP 23.3 because ubuntu-latest doesn't have that anymore * do not test OTP 25.2 && elixir 1.12.3 as they are not compatible * sadly old elixirs don't allow ƒ as macro names * use the new fancy test helper everywhere * first run over the docs, added some tests, improved some typespecs * next round over our docs, turned all code examples into doctests, added Wasmex.store(), added test for stdin->stdout echo * renamed Pipe.create to Pipe.new to be consistent with method naming * renamed Memory.length to Memory.size to be consistent with method naming * run CI under latest OTP/elixir; re-add arm-unknown-linux-gnueabihf release target * disable arm-unknown-linux-gnueabihf builds again * updated Elixir deps * wrote a CHANGELOG; minor doc updates * fix README, minor doc updates
Awesome work! I can't wait to try this version out soon. 🙇 |
thanks! can't wait for you to tell me how it went. :) Hope it's not too much work migrating to the new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #336, we want to switch the underlying WASM engine from wasmer to wasmtime. We prototyped that switch over at https://github.com/tessi/wasmex-wasmtime
This MR brings that experiment back into the main repo and polishes it.
TODOs