Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues with the CPack configurations:
Debian dependencies
Currently the dependencies of a package are passed into the
tesseract_cpack
macro as a list of strings.cmake
concatenates these entries into a semi-colon separated string. This is problematic for debians because they expect a comma-separated list of dependencies. I think NuGet packages have the same requirement, but I was not able to confirm. The solution was to replace the semi-colons in${ARG_<OS>_DEPENDS}
with commasDebian architecture name
The debians I initially created would not install because the specified architecture
x86_64
did not match the system architectureamd64
. The specified architecture currently comes from theCMAKE_SYSTEM_PROCESSOR
variable, which returnsx86_64
in my case. Per this document,x86_64
is not actually a valid debian architecture; the corresponding architecture should actually beamd64
. The solution was to change references fromx86_64
toamd64
for Linux builds. I'm not sure if Windows NuGet packages are affected the same way, so I didn't change anything there