Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker update documentation #1170

Merged
merged 1 commit into from
Jan 3, 2021

Conversation

fatbasstard
Copy link
Contributor

This PR adds some minor documentation about updating TeslaMate when installed with Docker.

This to help out with updating it when people are not too familiar with Docker.

Copy link
Collaborator

@adriankumpf adriankumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@adriankumpf adriankumpf merged commit 3beb816 into teslamate-org:master Jan 3, 2021
@cwanja
Copy link
Collaborator

cwanja commented Jan 10, 2021

Consider compressing it into a single command?
docker-compose down && docker system prune && docker-compose pull && docker-compose up -d
Not sure the prune is necessary, but I include it.

@DrJohnM61
Copy link

Consider compressing it into a single command?

`

docker-compose down && docker system prune && docker-compose pull && docker-compose up -d

`

Not sure the prune is necessary, but I include it.

The prune should logically go after the pull as it will clean up and redundant images created by pulling new (updated) images

@cwanja
Copy link
Collaborator

cwanja commented Jan 10, 2021 via email

@RobertPaulson90
Copy link

RobertPaulson90 commented Jan 22, 2021

Isn't the prune risky to run inbetween docker-compose down and docker-compose up -d? Won't it delete your data?

Use this instead: docker-compose down && docker-compose pull && docker-compose up -d && docker system prune

@cwanja
Copy link
Collaborator

cwanja commented Jan 22, 2021

Isn't the prune risky to run inbetween docker-compose down and docker-compose up -d? Won't it delete your data?

Use this instead: docker-compose down && docker-compose pull && docker-compose up -d && docker system prune

Never had a data loss issue with the docker system prune erasing data. But I am open to more suggestions and advice. Am not a Docker expect by any stretch.

@roadrash2108
Copy link
Contributor

It's already merged, but I wonder why the information is duplicated as it is in https://github.com/adriankumpf/teslamate/blob/master/website/docs/installation/docker.md and https://github.com/adriankumpf/teslamate/blob/master/website/docs/upgrading.mdx !?

IMHO this should be referenced in the installation-documentation, but not duplicated...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants