Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown values and displayed text swapped #524

Closed
tobiasehlert opened this issue Mar 21, 2020 · 1 comment
Closed

Dropdown values and displayed text swapped #524

tobiasehlert opened this issue Mar 21, 2020 · 1 comment

Comments

@tobiasehlert
Copy link
Collaborator

tobiasehlert commented Mar 21, 2020

Describe the bug

HTML code of dropdown Range (Preferred range) has two values (ideal and rated) and the english values should be the value inside the options dropdown and the displayed text should be the translated one.

This results in an error showing up right now, saying that the option is invalid. So you can not change the value right now :)

To Reproduce

Steps to reproduce the behavior:

  1. Go to Settings
  2. Click on Range dropdown
  3. Select one of the values
  4. See error

Expected behavior

As it is now:

<div class="select is-fullwidth">
    <select id="global_settings_preferred_range" name="global_settings[preferred_range]">
        <option value="idealisk" selected="">ideal</option>
        <option value="nominell">rated</option>
    </select>
</div>

As it should be:

<div class="select is-fullwidth">
    <select id="global_settings_preferred_range" name="global_settings[preferred_range]">
        <option value="ideal" selected="">idealisk</option>
        <option value="rated">nominell</option>
    </select>
</div>

Relevant entries from the logs

no

Screenshots

image

Data

no

Operating environment

  • TeslaMate Version: v1.18.0
  • Advanced Docker Setup with Traefik
  • OS: CentOS 8
@tobiasehlert
Copy link
Collaborator Author

created PR #525 for this :)

adriankumpf added a commit that referenced this issue Apr 6, 2020
* adding swedish translation

* adding comments from endlish errors.po

* adding new translations for swedish

* fix #524 of adriankumpf/teslamate

* adding translation for geo-fence in swedish

* fixing translation of charge limit in swedish

* fixiing translation of mileage in swedish

* Fix typos

* adding swedish translations

* adjustment of swedish translation suggested by Thomas Hennig

Co-authored-by: Adrian Kumpf <[email protected]>
adriankumpf added a commit that referenced this issue Apr 20, 2020
* adding swedish translation

* adding comments from endlish errors.po

* adding new translations for swedish

* fix #524 of adriankumpf/teslamate

* adding translation for geo-fence in swedish

* fixing translation of charge limit in swedish

* fixiing translation of mileage in swedish

* Fix typos

* adding swedish translations

* adjustment of swedish translation suggested by Thomas Hennig

* MQTT_HOST default should be 127.0.0.1 for screen, as in systemd

* adding drop_cap to traefik example, which all other guides have

* removing quotation marks around ports for portainer

* adjusting volumes for portainer to match other guides

Co-authored-by: Adrian Kumpf <[email protected]>
adriankumpf added a commit that referenced this issue Oct 24, 2020
* adding swedish translation

* adding comments from endlish errors.po

* adding new translations for swedish

* fix #524 of adriankumpf/teslamate

* adding translation for geo-fence in swedish

* fixing translation of charge limit in swedish

* fixiing translation of mileage in swedish

* Fix typos

* adding swedish translations

* adjustment of swedish translation suggested by Thomas Hennig

* MQTT_HOST default should be 127.0.0.1 for screen, as in systemd

* adding drop_cap to traefik example, which all other guides have

* removing quotation marks around ports for portainer

* adjusting volumes for portainer to match other guides

* fix #635 fr translation

* Minor adjustments to swedish translation

and removing translations that are the same as in english

Co-authored-by: Adrian Kumpf <[email protected]>
adriankumpf added a commit that referenced this issue Oct 24, 2020
* adding swedish translation

* adding comments from endlish errors.po

* adding new translations for swedish

* fix #524 of adriankumpf/teslamate

* adding translation for geo-fence in swedish

* fixing translation of charge limit in swedish

* fixiing translation of mileage in swedish

* Fix typos

* adding swedish translations

* adjustment of swedish translation suggested by Thomas Hennig

* MQTT_HOST default should be 127.0.0.1 for screen, as in systemd

* adding drop_cap to traefik example, which all other guides have

* removing quotation marks around ports for portainer

* adjusting volumes for portainer to match other guides

* fix #635 fr translation

* Minor adjustments to swedish translation

and removing translations that are the same as in english

Co-authored-by: Adrian Kumpf <[email protected]>
adriankumpf added a commit that referenced this issue Dec 1, 2020
…ber support (#1097)

* adding swedish translation

* adding comments from endlish errors.po

* adding new translations for swedish

* fix #524 of adriankumpf/teslamate

* adding translation for geo-fence in swedish

* fixing translation of charge limit in swedish

* fixiing translation of mileage in swedish

* Fix typos

* adding swedish translations

* adjustment of swedish translation suggested by Thomas Hennig

* MQTT_HOST default should be 127.0.0.1 for screen, as in systemd

* adding drop_cap to traefik example, which all other guides have

* removing quotation marks around ports for portainer

* adjusting volumes for portainer to match other guides

* fix #635 fr translation

* Minor adjustments to swedish translation

and removing translations that are the same as in english

* Adjusting TeslaMateAgile text to mention Tibber support

Co-authored-by: Adrian Kumpf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant