Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @turf/turf from 5.1.6 to 6.4.0 #472

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 28, 2021

Bumps @turf/turf from 5.1.6 to 6.4.0.

Changelog

Sourced from @​turf/turf's changelog.

6.4.0

🏅 New Features/Enhancements

🐛 Bug Fixes

📖 Documentation

🔔 Misc

6.3.0

Fix issues importing Turf for react-native, webpack 5, and other bundlers

(PR Turfjs/turf#2004 - Author r0b0t3d) (PR Turfjs/turf#2011 - Author mfedderly)

[@turf/turf][turf] expose @​turf/boolean-intersect

(PR Turfjs/turf#2007 - Author rowanwins)

6.2.0

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by rowanwins, a new releaser for @​turf/turf since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 28, 2021
@marcjansen
Copy link
Member

I dug a bit why this is failing, and here is what I found out so far:

  • Since v6.2.0-alpha.3 of turf, this commit (introduced in this PR) is included, which changed the buffer calculation due to changed projection handling. This explains all the coordinates which no longer match the one we are expecting in the buffer tests / maybe also elsewhere. I suggests to simply change our expectations in the tests. I am not 100% sure, though
  • I am a bit surprised that we do not have more buffer changes, because as I understand it, the number of steps per segments was never explicitly specified, and the default has changed on the turf side from 64 to 8 in this commit / this PR. I might misread this, of course. We could have the steps be explicitly set, to be on the safe side, I guess.
  • The warnings/errors Input geometry is not a valid Polygon or MultiPolygon when calling union with LineStrings (e.g. here) are to be expected, and as far as I understand never could have worked?! It looks as if union always expected (Multi)Polygons and nothing else. I am the wrong person to understand what exactly is going on this method. It needs bigger changes, I guess.

So far the results of my tiny investigations.

Bumps [@turf/turf](https://github.com/Turfjs/turf) from 5.1.6 to 6.4.0.
- [Release notes](https://github.com/Turfjs/turf/releases)
- [Changelog](https://github.com/Turfjs/turf/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Turfjs/turf/commits)

---
updated-dependencies:
- dependency-name: "@turf/turf"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/turf/turf-6.4.0 branch from fd58a62 to 77e8543 Compare July 2, 2021 15:56
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 12, 2021

Superseded by #480.

@dependabot dependabot bot closed this Jul 12, 2021
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/turf/turf-6.4.0 branch July 12, 2021 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant