Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mode generation for plugin-sass + plugin-css #202

Merged
merged 1 commit into from
Mar 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fast-wolves-shake.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cobalt-ui/cli": patch
---

Throw error on missing tokens.json
7 changes: 7 additions & 0 deletions .changeset/hip-llamas-sip.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@cobalt-ui/plugin-sass': minor
---

Fix collision of mode names if a user has a mode called `"default"`, changing the internal selector to `"."` (a single dot).

`"."` will be used more often in the upcoming [2.0 API](https://github.com/drwpow/cobalt-ui/issues/201), chosen because it’s easy to type/reference, uses illegal characters (therefore consumers can’t use it, but internally we know what it means), and also because it matches [Node’s ESM implementation for the default import](https://nodejs.org/docs/latest/api/esm.html#resolution-algorithm-specification), so it will be familiar/expected for some developers.
5 changes: 5 additions & 0 deletions .changeset/shiny-rats-grow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cobalt-ui/plugin-sass": patch
---

Fix plugin-sass mode generation
1,228 changes: 612 additions & 616 deletions examples/adobe/tokens/index.d.ts

Large diffs are not rendered by default.

Loading
Loading