Observations: Add indicators in Zones and Plots containing 25m sq plots #3307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nickgraz
reviewed
Oct 30, 2024
Comment on lines
17
to
20
| const has25mPlots = row.plantingSubzones | ||
| ?.flatMap((subzone: { monitoringPlots: any[] }) => subzone.monitoringPlots.flatMap((plot) => plot.sizeMeters)) | ||
| .some((size: number) => size.toString() === '25'); | ||
|
|
There was a problem hiding this comment.
Perhaps this should be a static util function that receives subzones? It seems to be duplicated 3 times.
There was a problem hiding this comment.
It is used twice for subzones, so I added a util for that. The other checks the zone.
nickgraz
reviewed
Oct 31, 2024
| @@ -134,6 +134,14 @@ export default function ObservationDetails(props: ObservationDetailsProps): JSX. | |||
| } | |||
| }, [zoneNames, searchProps.filtersProps]); | |||
|
|
|||
| const has25mPlots = details?.plantingZones | |||
| .flatMap((zone) => | |||
There was a problem hiding this comment.
Can you use the has25mPlots function here?
nickgraz
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added "Last observation: ... " in schedule observation modal