Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure timeout with D2_TIMEOUT #1392

Merged
merged 11 commits into from
Jun 15, 2023
Merged

configure timeout with D2_TIMEOUT #1392

merged 11 commits into from
Jun 15, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Jun 10, 2023 •
edited
Loading

Summary

For very large graphs we may want to configure d2 to run longer before timing out.

Details

  • e.g. use D2_TIMEOUT=180 d2 ... or d2 --timeout 180 ... to run d2 with a timeout after 3 minutes
  • also applies to plugins' layout and e2ereport

@gavin-ts gavin-ts marked this pull request as ready for review June 10, 2023 00:37
@gavin-ts gavin-ts requested a review from a team June 10, 2023 00:37
@gavin-ts gavin-ts enabled auto-merge June 10, 2023 00:41
alixander
alixander requested changes Jun 10, 2023
View reviewed changes
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a flag too. i don't think we have any environment variables that are not flags so don't see why this should be the first

e2etests/report/main.go Show resolved Hide resolved
ejulio-ts
ejulio-ts reviewed Jun 12, 2023
View reviewed changes
d2cli/main.go Outdated Show resolved Hide resolved
ejulio-ts
ejulio-ts reviewed Jun 14, 2023
View reviewed changes
d2cli/main.go Outdated Show resolved Hide resolved
lib/log/log.go Outdated Show resolved Hide resolved
@gavin-ts gavin-ts requested a review from ejulio-ts June 14, 2023 20:31
alixander
alixander requested changes Jun 14, 2023
View reviewed changes
d2cli/main.go Outdated Show resolved Hide resolved
alixander
alixander approved these changes Jun 14, 2023
View reviewed changes
ci/release/template/man/d2.1 Outdated Show resolved Hide resolved
d2cli/main.go Outdated Show resolved Hide resolved
alixander
alixander approved these changes Jun 14, 2023
View reviewed changes
ci/release/template/man/d2.1 Outdated Show resolved Hide resolved
@gavin-ts gavin-ts merged commit c4ba207 into terrastruct:master Jun 15, 2023
@Porkepix Porkepix mentioned this pull request Jul 31, 2023
Merged
@bo-ku-ra bo-ku-ra mentioned this pull request Aug 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

@ejulio-ts ejulio-ts Awaiting requested review from ejulio-ts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gavin-ts @alixander @ejulio-ts