Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout: end connections at outside labels #1381

Merged
merged 10 commits into from
Jun 9, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Jun 8, 2023

Summary

End connections at outside labels regardless if it is a container.
Previously we would stop dagre connections at outside container labels, but this wouldn't account for other scenarios such as the person shape having an outside bottom label position as a non-container.

Details

before/after

_Users_gavinnishizawa_github_repos_d2_e2etests_out_e2e_report html (1)

e2ereport

_Users_gavinnishizawa_github_repos_d2_e2etests_out_e2e_report html (2)

@gavin-ts gavin-ts requested a review from alixander June 8, 2023 21:24
@gavin-ts gavin-ts marked this pull request as ready for review June 8, 2023 21:24
@gavin-ts gavin-ts enabled auto-merge June 8, 2023 21:24
@gavin-ts gavin-ts requested a review from a team June 8, 2023 22:55
@gavin-ts gavin-ts merged commit 8dc1d9a into terrastruct:master Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants