Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

constraint improvements #1372

Merged
merged 2 commits into from
Jun 5, 2023
Merged

constraint improvements #1372

merged 2 commits into from
Jun 5, 2023

Conversation

alixander
Copy link
Collaborator

@alixander alixander commented Jun 5, 2023 •
edited
Loading

  1. Remove the letter-spacing from constraint, looks ugly.
  2. Make padding consistent
Screen Shot 2023-06-05 at 11 32 24 AM
  1. Render constraints even when they don't have abbreviation
Screen Shot 2023-06-05 at 11 33 44 AM
  1. Maintain Texts() to match

e2e delta

screencapture-file-Users-alexanderwang-dev-alixander-d2-e2etests-out-e2e-report-html-2023-06-05-11_30_33

@alixander alixander merged commit 69475c7 into terrastruct:master Jun 5, 2023
@alixander alixander deleted the measure-constraint branch June 5, 2023 18:43
@chenrui333 chenrui333 mentioned this pull request Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alixander