feat: Add text-transform attribute to the style block

[alexstoick]

This provides an option to override the functionality provided by the
theme, or apply text-transform outside of the theme.

The functionality of the text-transform is as below:

• text-transform: none - will disable any transformation (like the uppercasing by terminal theme)
• text-transform: uppercase (uppercase not upper as per your message) - will force all characters into uppercase.
• text-transform: lowercase - will force all characters into lowercase.
• text-transform: capitalize - will uppercase the first letter of every word

In addition, this commit introduces:

• helper methods on the d2graph.Style struct to determine the type of
  text-transform to be applied.
• ApplyTextTransform method on the d2graph.Attributes which will
  transform the Label.Value to the correct text case.

Screenshots pending.

Fixes: #1117

[alixander]

amazing, thanks so much for opening a PR for this.

1. your intuition is right about the boolean type, but we should make all of them typed in a refactor and test rigorously, vs having a temporary one-off type in the list of styles. (there's an issue for this: compiler: add different scalar types #285). could you use the same Scalar type here please?
2. Tests:

   d2/e2etests/themes_test.go

   Line 13 in a53eb48

   name: "terminal",

• Add a caps lock = false for an object in there
• Regenerate the test with TESTDATA_ACCEPT=1 ./ci/test.sh ./e2etests -run TestE2E/themes
• Check the output SVG to see that caps lock=false worked.

And then do that for another test to test capslock=true works.

[alexstoick]

@alixander - updated as per your comment:

• removed Boolean class. I kept the helper methods - as I think the duplication would be mad, but if you consider it's not in line with the rest of the style I can remove them 👍
• added tests & updated description with screenshots. Let me know if you think the other-user entry messes up the vibe of the origami test, and I will setup a whole new one 👍

[janydoe]

Maybe it would be better to make style.convertCase: upper (lower, pascal, title, etc)

[alixander]

@janydoe that's an interesting point, thank you for that suggestion. maybe we literally just do https://developer.mozilla.org/en-US/docs/Web/CSS/text-transform

yeah that's more flexible. i've found myself wanting to do capital casing sometimes, and i think many others would too, and I don't want separate keywords for that. So then the way to disable the theme's uppercasing is to do text-transform: none

Sorry for the moving goal post @alexstoick , would you mind changing to that? You can just support the values upper and none for this one to accomplish the original, and other values can be added later if that's easier

[alexstoick]

@alixander I'm happy to implement the text-transform spec. Just to be clear on desired behaviour:

• text-transform: none - will disable any transformation (like the uppercasing by terminal theme)
• text-transform: uppercase (uppercase not upper as per your message) - will force all characters into uppercase.
• text-transform: lowercase - will force all characters into lowercase.
• text-transform: capitalize - will uppercase the first letter of every word (defined by some separator) - I'll need to check if there is a helper method for this, or I might come back to you with a proposal.

If the above sounds good - LMK and I'll update the PR.

Thank you 🙇

[alixander]

@alexstoick sounds good to me!

[alexstoick]

@alixander - I've implemented the text-transform as requested; before I go ahead and add final touches to description (screenshots, etc) - let me know if this is 🆗 for you. I've changed a few of the tests to cover all of the text-transform options.

[alixander]

generally looks good to me, let's add tests and get this in, ty @alexstoick !

[alexstoick]

@alixander - when you say let's add tests - I have already updated some of the tests in e2e/themes; are there more tests that you would like to see on specific components, or new tests all together?

[alixander]

oh, i guess those tests do cover it all, nvm!

[alixander]

can you add a changelog here too please?

[alixander]

@alexstoick looks like a format error, if you run ./make.sh fmt it should fix

[alexstoick]

@alixander - yep; odd that my formatter didn't auto-fix. Updated now ✅

[alixander]

tested and works great, thanks @alexstoick