Update doc build to py313 #2050
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opotowsky
added
documentation
opotowsky
commented
Jan 10, 2025
Comment on lines
+102
to
+105
| globals = {} | ||
| exec(code, globals) | ||
|
|
||
| if result is None: | ||
| result = globals["usermethod"]() |
There was a problem hiding this comment.
I'm really not sure why the usermethod no longer shows up in locals.
I just tried globals on a whim and it was there. Is this dangerous?
opotowsky
commented
Jan 10, 2025
Comment on lines
-122
to
+120
| "Unable to execute embedded doc code at {}:{} ... {}\n{}".format( | ||
| docname, self.lineno, datetime.datetime.now(), str(e) | ||
| ) | ||
| f"Unable to execute embedded doc code at {docname}:{self.lineno}\n{str(e)}" |
There was a problem hiding this comment.
I found the timestamp really annoying and not useful when trying to debug a docs build. But you can certainly reject the edit if you disagree!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
The docs are being built with python 3.9. This updates them to python 3.13 (updating dependency pins in the process)
Why is the change being made?
Keepin' up with the times!
Checklist
docfolder.pyproject.toml.