Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing misleading comment in FuelHandler.swapCascade() #1910

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fixing misleading comment in FuelHandler.swapCascade() #1910

merged 1 commit into from
Sep 26, 2024

Conversation

john-science
Copy link
Member

What is the change?

Fixed a confusing and misleading comment in FuelHandler.swapCascade().

Why is the change being made?

Just cleanup

The comment was too casual, but also didn't adequately explain the issue. And it wasn't reflected in the log statement on the next line.

Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added cleanup Code/comment cleanup: Low Priority low priority Style points and non-features labels Sep 26, 2024
@john-science john-science merged commit 96a5c88 into main Sep 26, 2024
19 checks passed
@john-science john-science deleted the fix_fh_comment branch September 26, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewj-tp drewj-tp drewj-tp approved these changes

Assignees
No one assigned
Labels
cleanup Code/comment cleanup: Low Priority low priority Style points and non-features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-science @drewj-tp