fix #92 this.parseError is not a function #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for making this contribution @mpalmerlee. i'll make time to take a look at this soon. |
jgravois
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding a
parseErrorproperty to the parser.yy object we avoid the errorthis.parseError is not a functionand we can re-throw the underlying error with a more useful error message.This works because the
parser.yyobject gets copied to thesharedStateobject here:https://github.com/zaach/jison/blob/master/lib/jison.js#L1393
Then because
sharedState.parseErroris defined it is used rather than undefined here:https://github.com/zaach/jison/blob/master/lib/jison.js#L1409
Fixes #92