Fixing id:72514,id:68939,id:63139,id:63152 and updating proxy image #865
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
| // clusterArgs.OpenshiftVersion = helper.StringPointer(targetV) | ||
| // _, err = clusterService.Apply(clusterArgs) | ||
| // Expect(err).To(HaveOccurred()) | ||
| // Expect(err.Error()).To(ContainSubstring("Missing required acknowledgements to schedule upgrade")) |
There was a problem hiding this comment.
May I know why common above checkpoint of missing upgrade_acknowledge?
There was a problem hiding this comment.
There's currently a bug that causes the upgrade to occur even without acknowledging it. I left it commented out so that once that bug gets fixed, we can just re-enable the test. It's also already disabled for the HCP upgrade:
| By("Create github idp with empty hostname") | ||
| args = getDefaultGitHubArgs(idpName) | ||
| args.HostedDomain = helper.EmptyStringPointer | ||
| validateIDPArgAgainstErrorSubstrings(idpServices.github, args, "Attribute 'hostname' is mandatory") |
There was a problem hiding this comment.
Is there any reason to remove this above step By("Create github idp with empty hostname")?
There was a problem hiding this comment.
As far as I can tell creating an IDP without the hostname set is how you're supposed to create one that uses github.com, so it seems like it's not a mandatory argument anymore
What this PR does / why we need it: Fixes OCP-72514, OCP-68939, OCP-63139, and OCP-63152 tests. Also fixes installing a classic cluster with a proxy enabled
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story (OCM-xxxx):Fixes #OCM-13194
Change type
Checklist