Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-12837 | feat: support shared vpc attributes in cluster resource #856

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

gdbranco
Copy link
Contributor

@gdbranco gdbranco commented Nov 28, 2024

OCM-12837

Change type

  • New feature
  • Bug fix
  • Build
  • CI
  • Documentation
  • Performance
  • Refactor
  • Style
  • Unit tests
  • Subsystem tests

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

@openshift-ci openshift-ci bot requested review from vkareh and yasun1 November 28, 2024 22:35
@gdbranco gdbranco force-pushed the feat/ocm-12837 branch 6 times, most recently from 9955eab to 0dccfc2 Compare November 29, 2024 14:47
@gdbranco
Copy link
Contributor Author

/test e2e-presubmits-rosa-sts-advanced-critical-high-presubmit

@den-rgb
Copy link

den-rgb commented Dec 2, 2024

/lgtm

Copy link

openshift-ci bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gdbranco
Copy link
Contributor Author

gdbranco commented Dec 2, 2024

/test e2e-presubmits-rosa-sts-private-critical-high-presubmit

1 similar comment
@gdbranco
Copy link
Contributor Author

gdbranco commented Dec 2, 2024

/test e2e-presubmits-rosa-sts-private-critical-high-presubmit

@openshift-merge-bot openshift-merge-bot bot merged commit 831e6e6 into terraform-redhat:main Dec 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants