OCM-12269 | ci: fix with reducing the number of sg in id:73068 #837
Conversation
|
/retest |
1 similar comment
|
/retest |
yuwang-RH
force-pushed
the
fix73068
branch
5 times, most recently
from
b2d4285 to
bb057a9
Compare
|
@xueli181114 @jerichokeyne Could you help review this PR?Thanks. |
| errs = append(errs, err) | ||
| if strings.Contains(err.Error(), "DependencyViolation") { | ||
| Logger.Warnf("DependencyViolation, waiting for 15 minutes before retrying. The error is %v", err) | ||
| time.Sleep(15 * time.Minute) |
There was a problem hiding this comment.
Maybe it's better to use for loop rather than sleeping 15 mins?
There was a problem hiding this comment.
The time it takes to destroy vpc is uncertain; sometimes it's longer, sometimes shorter, it almost takes about 20min ,so here we only want to retry once with an interval based on experience.
Considering it is a sporadic issue, although the probability of it occurring is a bit high recently, I will add comment to declare the time.sleep is just a workaround, will be removed in future if the dependency can be deleted before the vpc destroy. What do you think about it?
|
/retest |
|
@yuwang-RH: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xueli181114 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 178dcd7
into
terraform-redhat:main
OCM-12269 | ci: fix with reducing the number of sg in id:73068