Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6031 | feat: allow to edit component routes of ingress #568

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

gdbranco
Copy link
Contributor

@gdbranco gdbranco commented Mar 7, 2024

OCM-6031

Change type

  • New feature
  • Bug fix
  • Build
  • CI
  • Documentation
  • Performance
  • Refactor
  • Style
  • Unit tests
  • Subsystem tests

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

@openshift-ci openshift-ci bot requested review from AsherShoshan and jneczypor March 7, 2024 19:47
@gdbranco
Copy link
Contributor Author

/hold
Until we have 1.6.0

@gdbranco
Copy link
Contributor Author

gdbranco commented Apr 8, 2024

/unhold

@nirarg
Copy link
Member

nirarg commented Apr 9, 2024

/approve

@openshift-ci openshift-ci bot added the approved label Apr 9, 2024
Copy link
Contributor

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gdbranco
Copy link
Contributor Author

gdbranco commented Apr 9, 2024

/retest

@openshift-ci openshift-ci bot removed the lgtm label Apr 9, 2024
@gdbranco
Copy link
Contributor Author

gdbranco commented Apr 9, 2024

/retest

2 similar comments
@gdbranco
Copy link
Contributor Author

gdbranco commented Apr 9, 2024

/retest

@gdbranco
Copy link
Contributor Author

/retest

Copy link
Contributor

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 11, 2024
Copy link

openshift-ci bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche, nirarg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1e80fd9 into terraform-redhat:main Apr 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants