Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-5627 | ci: upgrade scenario test cases #507

Merged

Conversation

Copy link

openshift-ci bot commented Jan 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@amalykhi amalykhi changed the title OCM-5627 | CI : Upgrade scenario test cases OCM-5627: Upgrade scenario test cases Jan 16, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 16, 2024

@amalykhi: This pull request references OCM-5627 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

https://polarion.engineering.redhat.com/polarion/#/project/OSE/workitem?id=OCP-63153

https://polarion.engineering.redhat.com/polarion/#/project/OSE/workitem?id=OCP-63825

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@amalykhi amalykhi changed the title OCM-5627: Upgrade scenario test cases OCM-5627|CI: Upgrade scenario test cases Jan 16, 2024
@openshift-ci-robot
Copy link

@amalykhi: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

https://polarion.engineering.redhat.com/polarion/#/project/OSE/workitem?id=OCP-63153

https://polarion.engineering.redhat.com/polarion/#/project/OSE/workitem?id=OCP-63825

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@amalykhi amalykhi changed the title OCM-5627|CI: Upgrade scenario test cases OCM-5627 | CI: Upgrade scenario test cases Jan 16, 2024
@amalykhi amalykhi changed the title OCM-5627 | CI: Upgrade scenario test cases OCM-5627 | ci: Upgrade scenario test cases Jan 16, 2024
@amalykhi amalykhi force-pushed the upgradescenario branch 5 times, most recently from 2baa42a to 54db484 Compare January 18, 2024 11:14
@nirarg
Copy link
Member

nirarg commented Jan 18, 2024

/retest

@shellymiron
Copy link
Contributor

/lgtm
can you show a run for it?

@amalykhi
Copy link
Contributor Author

@amalykhi @shellymiron @xueli181114 Some additional common comments. You may have some discussion and conclusion before, I just confirm with you here.

  • Is there any definitions for the cluster profile using for upgrade cases? If no, do we want to use an advanced clusters to make sure the upgrading testing runing on a more customized clusters or use a basic cluster on a bisic cluster? It is more like basic clusters in the PR.
  • We hardcode the major_version as 4.14. What will we do when 4.14.z->4.15.z path is available?
  • I understand the 'update cluster' means uprading cluster within z stream while 'upgrade cluster' means upgrading cluster within Y stream here. Do we want the test title like this, upgrade cluster within Y/Z stream more explicit for me.

And @amalykhi Is there any other cases for the validations about upgrade clusters? Like empty upgrade version, invalid upgrade version, etc. If no, please add the checkpoint in these two cases.

There is no definition of upgrade case profile AFAIK, Does it exist for OCM/rosa CLI?
Once 4.15 is released we are going to upgrade this in the repo - Release will require changes in the openshift/release.
For example, there are 4.15 versions exist in candidate channel, but I would like to verify latest GAed version

Regarding the label name, both looks fine for me, just wanted to separate the test cases between Y and Z stream upgrades.
@xueli181114 @shellymiron WDYT?

@amalykhi amalykhi force-pushed the upgradescenario branch 5 times, most recently from 661a791 to 58bd782 Compare January 24, 2024 13:58
@amalykhi amalykhi force-pushed the upgradescenario branch 3 times, most recently from 3ea6513 to 4c51eb0 Compare February 5, 2024 10:52
@amalykhi
Copy link
Contributor Author

amalykhi commented Feb 5, 2024

/unhold

@amalykhi amalykhi changed the title OCM-5627 | ci: Upgrade scenario test cases OCM-5627 | ci: upgrade scenario test cases Feb 5, 2024
@shellymiron
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 5, 2024
@openshift-ci openshift-ci bot removed the lgtm label Feb 5, 2024
@shellymiron
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 5, 2024
@yuwang-RH
Copy link
Contributor

/lgmt

@shellymiron
Copy link
Contributor

/approve

2 similar comments
@xueli181114
Copy link
Contributor

/approve

@nirarg
Copy link
Member

nirarg commented Feb 7, 2024

/approve

Copy link

openshift-ci bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirarg, shellymiron, xueli181114

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2164128 into terraform-redhat:main Feb 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants